Skip to content

feat(storage): log effective gRPC transport configuration for DirectPath over Interconnect - #15026

Open
nidhiii-27 wants to merge 2 commits into
mainfrom
feat/storage-dp-interconnect-channel-diagnostics
Open

nidhiii-27 wants to merge 2 commits into
mainfrom
feat/storage-dp-interconnect-channel-diagnostics

Conversation

@nidhiii-27

@nidhiii-27 nidhiii-27 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds startup gRPC transport classification and configuration diagnostics for DirectPath over Cloud Interconnect (DP over GCI) in google-cloud-storage.

Key Changes

  • GrpcChannelTelemetry:
    • URI and host classification helpers (hasQueryParameter, detectTransportType, extractHost, isDirectPathInterconnectHost, grpcForceXdsIsSupported, isDirectPathInterconnectEnabled, resolveEffectiveTarget) for CloudPath, DirectPath, and DirectPathInterconnect, reusing OpenTelemetryBootstrappingUtils.extractServerAddress for host parsing.
    • Startup diagnostic logging (logChannelConfiguration) reporting actionable WARNING and INFO messages for DirectPath over Cloud Interconnect configuration, runtime gRPC force-xds support, and cases where setAttemptDirectPath(false) or unauthenticated/custom endpoint settings override setAttemptDirectPathXdsOverInterconnect(true).
  • GrpcStorageOptions:
    • Fixes builder precedence so setAttemptDirectPath(false) disables DirectPath even when setAttemptDirectPathXdsOverInterconnect(true) or GOOGLE_CLOUD_ENABLE_DIRECT_PATH_XDS_OVER_INTERCONNECT=true is set.
    • Wires GrpcChannelTelemetry.logChannelConfiguration into resolveSettingsAndOpts.
  • GrpcChannelTelemetryTest:
    • Focused unit tests covering URI/host classification, startup diagnostic logs and warnings, environment variable precedence, and builder precedence.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces GrpcChannelTelemetry to monitor and log gRPC channel connectivity states and record channel creation latency metrics using OpenTelemetry. It integrates this telemetry into GrpcStorageOptions via a channel primer and adds comprehensive unit tests in GrpcChannelTelemetryTest. The review feedback recommends refactoring the telemetry implementation to avoid using a static ScheduledExecutorService (DEFAULT_SCHEDULER), which can lead to classloader leaks in containerized environments. Instead, it is suggested to pass the managed executor service from StorageOptions through the channel primer and telemetry start methods, updating the tests accordingly.

@nidhiii-27 nidhiii-27 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2026
@nidhiii-27
nidhiii-27 force-pushed the feat/storage-dp-interconnect-channel-diagnostics branch from 3718a90 to af5482f Compare November 18, 2026 06:51
@nidhiii-27 nidhiii-27 changed the title feat(storage): log effective gRPC transport and channel connection readiness feat(storage): log effective gRPC transport configuration for DirectPath over Interconnect Nov 18, 2026
@nidhiii-27 nidhiii-27 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2026
@nidhiii-27 nidhiii-27 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2026
@nidhiii-27
nidhiii-27 marked this pull request as ready for review November 18, 2026 10:20
@nidhiii-27
nidhiii-27 requested review from a team as code owners November 18, 2026 10:20
@nidhiii-27 nidhiii-27 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull Request generated by AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants