Repository navigation
feat(storage): log effective gRPC transport configuration for DirectPath over Interconnect - #15026
Open
nidhiii-27 wants to merge 2 commits into
Open
nidhiii-27 wants to merge 2 commits into
nidhiii-27 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces GrpcChannelTelemetry to monitor and log gRPC channel connectivity states and record channel creation latency metrics using OpenTelemetry. It integrates this telemetry into GrpcStorageOptions via a channel primer and adds comprehensive unit tests in GrpcChannelTelemetryTest. The review feedback recommends refactoring the telemetry implementation to avoid using a static ScheduledExecutorService (DEFAULT_SCHEDULER), which can lead to classloader leaks in containerized environments. Instead, it is suggested to pass the managed executor service from StorageOptions through the channel primer and telemetry start methods, updating the tests accordingly.
…ath over Interconnect [Generated-by: AI]
nidhiii-27
force-pushed
the
feat/storage-dp-interconnect-channel-diagnostics
branch
from
November 18, 2026 06:51
3718a90 to
af5482f
Compare
…nostics and tests [Generated-by: AI]
nidhiii-27
marked this pull request as ready for review
November 18, 2026 10:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds startup gRPC transport classification and configuration diagnostics for DirectPath over Cloud Interconnect (DP over GCI) in
google-cloud-storage.Key Changes
GrpcChannelTelemetry:hasQueryParameter,detectTransportType,extractHost,isDirectPathInterconnectHost,grpcForceXdsIsSupported,isDirectPathInterconnectEnabled,resolveEffectiveTarget) forCloudPath,DirectPath, andDirectPathInterconnect, reusingOpenTelemetryBootstrappingUtils.extractServerAddressfor host parsing.logChannelConfiguration) reporting actionableWARNINGandINFOmessages for DirectPath over Cloud Interconnect configuration, runtime gRPCforce-xdssupport, and cases wheresetAttemptDirectPath(false)or unauthenticated/custom endpoint settings overridesetAttemptDirectPathXdsOverInterconnect(true).GrpcStorageOptions:setAttemptDirectPath(false)disables DirectPath even whensetAttemptDirectPathXdsOverInterconnect(true)orGOOGLE_CLOUD_ENABLE_DIRECT_PATH_XDS_OVER_INTERCONNECT=trueis set.GrpcChannelTelemetry.logChannelConfigurationintoresolveSettingsAndOpts.GrpcChannelTelemetryTest: